Create multiple chat rooms in one request#134
Merged
guusdk merged 4 commits intoigniterealtime:mainfrom Jul 31, 2022
Merged
Conversation
guusdk
requested changes
Jul 27, 2022
Member
guusdk
left a comment
There was a problem hiding this comment.
Would it make sense to group the results by result type? That is most likely how the returned object is going to be consumed anyway. I am easily convinced otherwise though.
In any case, please add:
- a reference to the changelog to the issue that you fixed.
@Schemaannotations to the newly added entities, for documentation purposes (as explained in #133)- the new endpoints to the documentation provided in the file
readme.md.
Afterwards, you can regenerate the readme.html file as described in the commit message of 315922b, but lets do that just once (to include all changes from all of the PRs that you are creating). This will prevent merge conflicts.
Member
|
Thanks! One issue that popped up during testing is that rooms that already exist can be 'created' again. This, however, is pre-existing behavior. I have created a new issue for this problem: #140 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New endpoint to create multiple chatrooms in one go. Fixes #127.