Skip to content

Create multiple chat rooms in one request#134

Merged
guusdk merged 4 commits intoigniterealtime:mainfrom
evdherberg:feature/127-create-multiple-rooms
Jul 31, 2022
Merged

Create multiple chat rooms in one request#134
guusdk merged 4 commits intoigniterealtime:mainfrom
evdherberg:feature/127-create-multiple-rooms

Conversation

@evdherberg
Copy link
Contributor

New endpoint to create multiple chatrooms in one go. Fixes #127.

@evdherberg evdherberg requested a review from guusdk July 25, 2022 10:04
Copy link
Member

@guusdk guusdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to group the results by result type? That is most likely how the returned object is going to be consumed anyway. I am easily convinced otherwise though.

In any case, please add:

  • a reference to the changelog to the issue that you fixed.
  • @Schema annotations to the newly added entities, for documentation purposes (as explained in #133)
  • the new endpoints to the documentation provided in the file readme.md.

Afterwards, you can regenerate the readme.html file as described in the commit message of 315922b, but lets do that just once (to include all changes from all of the PRs that you are creating). This will prevent merge conflicts.

@evdherberg evdherberg requested a review from guusdk July 30, 2022 20:47
@guusdk guusdk merged commit fa16a09 into igniterealtime:main Jul 31, 2022
@guusdk
Copy link
Member

guusdk commented Jul 31, 2022

Thanks! One issue that popped up during testing is that rooms that already exist can be 'created' again. This, however, is pre-existing behavior. I have created a new issue for this problem: #140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add endpoint that allows for more than one MUC room to be created with one request.

2 participants