Skip to content

Conversation

@szhorvat
Copy link
Member

@szhorvat szhorvat commented Feb 4, 2024

Attempted fix for #1173 (comment)

CC @Antonov548, not sure I covered everything.

@aviator-app
Copy link
Contributor

aviator-app bot commented Feb 4, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat szhorvat marked this pull request as ready for review February 4, 2024 21:26
@szhorvat
Copy link
Member Author

szhorvat commented Feb 4, 2024

@krlmlr Can we please have this in phoenix, and include it in the Tuesday release, without the pressure to spend time on extra tests? This fixes some memory leaks of the type discovered in #1173 (comment)

I untangled the manual changes in rinterface.c from the ones due to this bugfix. Hopefully I didn't make a mistake.

@krlmlr
Copy link
Contributor

krlmlr commented Feb 4, 2024

Thanks!

@aviator-app aviator-app bot merged commit ac5615b into main Feb 4, 2024
@aviator-app aviator-app bot deleted the fix/memleaks branch February 4, 2024 21:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants