Skip to content

Conversation

@szhorvat
Copy link
Member

@szhorvat szhorvat commented Feb 6, 2024

No description provided.

@aviator-app
Copy link
Contributor

aviator-app bot commented Feb 6, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat szhorvat force-pushed the feat/realize_bipartite_degree_sequence branch from 4ec5124 to 24b5ef5 Compare February 6, 2024 20:16
@szhorvat
Copy link
Member Author

szhorvat commented Feb 6, 2024

@krlmlr @maelle I need your help here. I'm not sure how to best deal with this:

> realize_bipartite_degseq(c(1,1), c(2))
Error in match.arg(arg = arg, choices = choices, several.ok = several.ok) : 
  'arg' must be of length 1

This comes from match.args() happening in realize_bipartite_degree_sequence_impl and not in realize_bipartite_degseq. Can you suggest specific code to fix this?

@szhorvat
Copy link
Member Author

szhorvat commented Feb 6, 2024

I pushed a commit with one possible fix. Let me know if this is the idiomatic way to handle this.

@szhorvat
Copy link
Member Author

szhorvat commented Feb 6, 2024

@maelle I'm confused about why the pkgdown test fails. The documentation of this function is structured exactly the same way as that of realize_degseq(). What is the difference between them that causes the failure?

@krlmlr
Copy link
Contributor

krlmlr commented Feb 8, 2024

The repeated argument matching seems like a safe way to handle this, yes.

We need to add this and every other new function to _pkgdown.yml . Some are added automatically via concepts or name patterns:

rigraph/_pkgdown.yml

Lines 39 to 42 in 4875489

- contents:
- starts_with("make_")
- realize_degseq
- has_concept("deterministic constructors")

@szhorvat szhorvat force-pushed the feat/realize_bipartite_degree_sequence branch from 735baaf to 3aceb4a Compare February 8, 2024 08:41
@szhorvat szhorvat marked this pull request as ready for review February 8, 2024 08:41
@krlmlr
Copy link
Contributor

krlmlr commented Feb 8, 2024

Thanks!

@aviator-app aviator-app bot force-pushed the feat/realize_bipartite_degree_sequence branch from 3aceb4a to f2cc6a3 Compare February 8, 2024 20:03
@aviator-app aviator-app bot merged commit 46fc512 into main Feb 8, 2024
@aviator-app aviator-app bot deleted the feat/realize_bipartite_degree_sequence branch February 8, 2024 20:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants