Skip to content

Conversation

@szhorvat
Copy link
Member

@szhorvat szhorvat commented Oct 4, 2024

…led in fit_power_law() with the plfit method

This PR is to help make quicker progress on #1158. It is not finished: a decision must be made on the interface of requesting a p-value calculation. Please see #1158 (comment)

Can someone please take this over from here?

@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 4, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

…led in `fit_power_law()` with the plfit method
@krlmlr krlmlr changed the title refactor: The precision of the p-value calculation can now be control… feat: Add p.value and p.precision arguments to fit_power_law() to control the computation of the p-value Oct 17, 2024
@krlmlr krlmlr requested a review from maelle October 17, 2024 12:33
@aviator-app aviator-app bot removed the mergequeue label Oct 17, 2024
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 17, 2024

This pull request can't be queued because it's currently a draft.

@krlmlr krlmlr marked this pull request as ready for review October 17, 2024 12:33
@aviator-app aviator-app bot added the blocked label Oct 17, 2024
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 17, 2024

This pull request failed to merge: some required checks failed. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed checks: Check ubuntu-20.04 (oldrel-2), Check ubuntu-20.04 (release)

@krlmlr krlmlr removed the blocked label Oct 17, 2024
@aviator-app aviator-app bot added the blocked label Oct 17, 2024
@aviator-app
Copy link
Contributor

aviator-app bot commented Oct 17, 2024

This pull request failed to merge: some required checks failed. After you have resolved the problem, you should remove the blocked pull request label from this PR and then try to re-queue the PR. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Failed checks: Check ubuntu-20.04 (oldrel-1), Check ubuntu-20.04 (oldrel-3)

@szhorvat
Copy link
Member Author

szhorvat commented Oct 17, 2024

@krlmlr Thanks for taking this over! Let me know if you need any help/input from me specifically.

@krlmlr krlmlr removed the blocked label Oct 17, 2024
@aviator-app aviator-app bot merged commit 1103b80 into main Oct 17, 2024
@aviator-app aviator-app bot deleted the power-law-fit branch October 17, 2024 14:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants