Pie chart section border radius support#2040
Closed
Mellow-Developer wants to merge 3 commits intoimaNNeo:mainfrom
Closed
Pie chart section border radius support#2040Mellow-Developer wants to merge 3 commits intoimaNNeo:mainfrom
Mellow-Developer wants to merge 3 commits intoimaNNeo:mainfrom
Conversation
…r radius with amount of 8)
…visual artifacts + Revert changes in pie_chart_sample2.dart
Owner
|
I don't think throwing an exception is a good idea; it's better to handle it gracefully (maybe by clamping it) So let's go ahead with that one. I'll mention your PR there, so we can get idea from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the support for border radius on pie chart sections.
There is a limitation for now that border radius must be only in a range of 0-8px. otherwise it throws exception.