Merged
Conversation
Previously it had members with no motivated order and ABI. We now have the case that the costly operation is extracting the index via a mask so let us make sure it is an integer where all operations are a bitshift away.
This was referenced Apr 8, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously it had members with no motivated order and ABI. We now have the case that the costly operation is extracting the index via a mask so let us make sure it is an integer where all operations are a bitshift away.
~1.5-2% faster on all benchmarks.
As an interesting artifact,
deriveandderive_burstnow generate single movs for Link-table entries where the previously generate three individual ones for each field (bycargo asm). That's odd; there is no semantic change that would have made it incorrect to fuse these.