ccd_asi: correction about binning size (BREAKING CHANGE)#671
Open
tail-feather wants to merge 2 commits intoindigo-astronomy:masterfrom
Open
ccd_asi: correction about binning size (BREAKING CHANGE)#671tail-feather wants to merge 2 commits intoindigo-astronomy:masterfrom
tail-feather wants to merge 2 commits intoindigo-astronomy:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ASI294MC Pro is currently listed with the following image sizes:
However, the 1381x940 resolution, which is 3x3 binning, will fail to capture the image.
According to the SDK manual (page 9 of the ASICamera2 Software Development Kit.pdf), the binning image size must be a value divisible by 8 for X and divisible by 2 for Y.
Following this note, the correct image size is as follows:
NOTE: This modification will result in a breaking change as it alters the size of the binning image.