fix(stdlib): mark HTTP POST examples not to run#5583
Merged
Conversation
It seems reqres.in has stopped working the way it used to, so the examples in the http/request.post and experimental/http/request.post documentation no longer work. Mark the with no_run to prevent test failures.
jdockerty
approved these changes
Dec 3, 2025
Member
jdockerty
left a comment
There was a problem hiding this comment.
Is there a requirement to follow-up making this work again or changing the example to use a different library?
Contributor
Author
I don't think so. The example is still fine for documentation, it just doesn't work if executed. It seems a bit dodgy relying on a third-party service for ones tests to pass in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems reqres.in has stopped working the way it used to, so the examples in the http/request.post and experimental/http/request.post documentation no longer work. Mark them with no_run to prevent test failures.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.