Skip to content

fix(stdlib): mark HTTP POST examples not to run#5583

Merged
mhilton merged 1 commit intomasterfrom
mhilton/http-docs-update
Dec 3, 2025
Merged

fix(stdlib): mark HTTP POST examples not to run#5583
mhilton merged 1 commit intomasterfrom
mhilton/http-docs-update

Conversation

@mhilton
Copy link
Contributor

@mhilton mhilton commented Dec 3, 2025

It seems reqres.in has stopped working the way it used to, so the examples in the http/request.post and experimental/http/request.post documentation no longer work. Mark them with no_run to prevent test failures.

Checklist

Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.

  • ✏️ Write a PR description, regardless of triviality, to include the value of this PR
  • 🔗 Reference related issues
  • 🏃 Test cases are included to exercise the new code
  • 🧪 If new packages are being introduced to stdlib, link to Working Group discussion notes and ensure it lands under experimental/
  • 📖 If language features are changing, ensure docs/Spec.md has been updated

Dear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.

It seems reqres.in has stopped working the way it used to, so the
examples in the http/request.post and experimental/http/request.post
documentation no longer work. Mark the with no_run to prevent test
failures.
@mhilton mhilton requested review from a team as code owners December 3, 2025 08:24
@mhilton mhilton requested review from sanderson and removed request for a team December 3, 2025 08:24
Copy link
Member

@jdockerty jdockerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a requirement to follow-up making this work again or changing the example to use a different library?

@mhilton
Copy link
Contributor Author

mhilton commented Dec 3, 2025

Is there a requirement to follow-up making this work again or changing the example to use a different library?

I don't think so. The example is still fine for documentation, it just doesn't work if executed. It seems a bit dodgy relying on a third-party service for ones tests to pass in the first place.

@mhilton mhilton merged commit 77da640 into master Dec 3, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants