feat: add missing deps for crossbuilder#2823
Merged
Conversation
jdstrand
reviewed
Jun 11, 2024
Contributor
jdstrand
left a comment
jdstrand
left a comment
There was a problem hiding this comment.
Thanks for the PR! It's surprising to me how many hoops we need to jump through to build this now, but I understand that's the case and this is largely based on what we were already doing in the edge repo.
That said, looking at this PRs CircleCI checks, I don't see anything about ARM. Where can we see the new builds using the updated crossbuilder? (I feel like I'm missing something obvious...)
jdstrand
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add missing builders toolchain to our custom builder.
Required checklist