fix(agent): Error out if configuration directory is not readable#18572
Merged
mstrandboge merged 11 commits intoinfluxdata:masterfrom Mar 27, 2026
Merged
fix(agent): Error out if configuration directory is not readable#18572mstrandboge merged 11 commits intoinfluxdata:masterfrom
mstrandboge merged 11 commits intoinfluxdata:masterfrom
Conversation
skartikey
reviewed
Mar 19, 2026
Contributor
skartikey
left a comment
There was a problem hiding this comment.
@srebhan Thanks for the fix! The change to error out on unreadable config directories is solid.
The test failures on Linux and Windows CI are likely because TestLoadConfigurationsPermissions relies on Unix file permission enforcement, which doesn't hold when running as root (common in Docker-based CI) or on Windows. Adding skip guards should fix it:
if runtime.GOOS == "windows" {
t.Skip("Unix file permissions not supported on Windows")
}
if os.Getuid() == 0 {
t.Skip("Cannot test permission restrictions as root")
}
skartikey
reviewed
Mar 23, 2026
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
skartikey
approved these changes
Mar 23, 2026
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
mstrandboge
approved these changes
Mar 27, 2026
srebhan
added a commit
that referenced
this pull request
Mar 30, 2026
) Co-authored-by: skartikey <s.kartikey@gmail.com> (cherry picked from commit 5d40e2a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently Telegraf will silently ignore any configuration directory specified via command-line if this directory cannot be read by the Telegraf user. This is bad because users will see missing plugins but get no indication whatsoever on what is going on.
This PR will error out if the directory cannot be read.
Checklist
Related issues
resolves #16600