chore(outputs): Add error handling for creating a buffer#18573
Merged
skartikey merged 1 commit intoinfluxdata:masterfrom Mar 24, 2026
Merged
chore(outputs): Add error handling for creating a buffer#18573skartikey merged 1 commit intoinfluxdata:masterfrom
skartikey merged 1 commit intoinfluxdata:masterfrom
Conversation
This was referenced Mar 19, 2026
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
mstrandboge
approved these changes
Mar 23, 2026
skartikey
approved these changes
Mar 24, 2026
srebhan
added a commit
that referenced
this pull request
Mar 30, 2026
(cherry picked from commit 4c98036)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using disk-based buffering, creating a new buffer instance can fail, e.g. due to permission issues or corrupted existing WAL files. This PR passes potential errors up from the
NewRunningOutputto theaddOutputfunction to do proper error reporting instead of panicking.Checklist
Related issues
resolves #18082
resolves #18528