Skip to content

chore(outputs): Add error handling for creating a buffer#18573

Merged
skartikey merged 1 commit intoinfluxdata:masterfrom
srebhan:buffer_error_handling
Mar 24, 2026
Merged

chore(outputs): Add error handling for creating a buffer#18573
skartikey merged 1 commit intoinfluxdata:masterfrom
srebhan:buffer_error_handling

Conversation

@srebhan
Copy link
Copy Markdown
Member

@srebhan srebhan commented Mar 19, 2026

Summary

When using disk-based buffering, creating a new buffer instance can fail, e.g. due to permission issues or corrupted existing WAL files. This PR passes potential errors up from the NewRunningOutput to the addOutput function to do proper error reporting instead of panicking.

Checklist

Related issues

resolves #18082
resolves #18528

@telegraf-tiger
Copy link
Copy Markdown
Contributor

@srebhan srebhan added the plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins label Mar 20, 2026
@mstrandboge mstrandboge removed their assignment Mar 23, 2026
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 23, 2026
Copy link
Copy Markdown
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Thanks! One minor comment.

Comment thread models/buffer_disk.go
@skartikey skartikey merged commit 4c98036 into influxdata:master Mar 24, 2026
27 checks passed
@github-actions github-actions Bot added this to the v1.38.2 milestone Mar 24, 2026
srebhan added a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic when using disk buffer strategy Panic if disk buffer directory can't be creatd

3 participants