Skip to content

Infer compatibility mode from version specs and fallback to node info only if necessary#4181

Merged
romac merged 6 commits intomasterfrom
romac/compat-mode-fetch
Sep 5, 2024
Merged

Infer compatibility mode from version specs and fallback to node info only if necessary#4181
romac merged 6 commits intomasterfrom
romac/compat-mode-fetch

Conversation

@romac
Copy link
Contributor

@romac romac commented Sep 3, 2024

Closes: #4178


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@romac romac marked this pull request as ready for review September 3, 2024 11:26
@romac romac merged commit aeca07b into master Sep 5, 2024
@romac romac deleted the romac/compat-mode-fetch branch September 5, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undefined behaviour with compat_mode 0.37

1 participant