Skip to content
This repository was archived by the owner on Mar 10, 2026. It is now read-only.

feat(YouTube): add Hook download actions patch#70

Merged
inotia00 merged 3 commits into
inotia00:devfrom
Francesco146:rvx-dev
Aug 6, 2024
Merged

feat(YouTube): add Hook download actions patch#70
inotia00 merged 3 commits into
inotia00:devfrom
Francesco146:rvx-dev

Conversation

@Francesco146
Copy link
Copy Markdown

Co-authored-by: Hoàng Gia Bảo <70064328+YT-Advanced@users.noreply.github.com>
Co-authored-by: inotia00 <108592928+inotia00@users.noreply.github.com>
@YT-Advanced
Copy link
Copy Markdown

@Francesco146 Seem like we forgot about the external downloader package name field

@AlexDeFoc
Copy link
Copy Markdown

yes, tiny oopsie :))

Comment thread src/main/resources/youtube/settings/host/values/arrays.xml Outdated
Comment thread src/main/resources/youtube/settings/xml/revanced_prefs.xml
Comment thread src/main/resources/youtube/settings/xml/revanced_prefs.xml
@inotia00
Copy link
Copy Markdown
Owner

inotia00 commented Aug 6, 2024

I tried to apply code review, but I don't have access to the PR repository, so I will manually edit it after merging

Thanks anyway

@inotia00 inotia00 changed the title feat(YouTube/Download Playlist Button): add playlist download button feat(YouTube): add Hook download actions patch Aug 6, 2024
@inotia00 inotia00 merged commit d647061 into inotia00:dev Aug 6, 2024
@Francesco146
Copy link
Copy Markdown
Author

i'm in a country that doesn't have this feature, how can you get that flyout menu?

@Francesco146
Copy link
Copy Markdown
Author

Francesco146 commented Aug 7, 2024

with the current implementation there's no "Download Playlist" button in the flyout menu

@Francesco146
Copy link
Copy Markdown
Author

no, i meant in my country that button is not visible

@Francesco146 Francesco146 deleted the rvx-dev branch August 7, 2024 13:09
@Yunkah99
Copy link
Copy Markdown

Yunkah99 commented Aug 7, 2024

Download is not working. I selected Seal but the dl button doesn't open it.

@Turhvjbufv
Copy link
Copy Markdown

Download is not working. I selected Seal but the dl button doesn't open it.
Then create a bug report, no need to spam here

@Francesco146
Copy link
Copy Markdown
Author

#71

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants