Skip to content

Imported events update#599

Closed
cryhot wants to merge 3 commits intoinsanum:masterfrom
cryhot:imported-events-update
Closed

Imported events update#599
cryhot wants to merge 3 commits intoinsanum:masterfrom
cryhot:imported-events-update

Conversation

@cryhot
Copy link
Copy Markdown

@cryhot cryhot commented May 23, 2021

This answers the same issues as pull request #584 (comment) (issues #492, #583), but actually updates the event (similarly to the google calendar "import" feature) instead of creating duplicates events or returning an error.

When using the command import on a .ics file with a specified UID, use the import method instead of the insert method.
I've tested it and it works as intended (the event is replaced if already existing in the specified calendar).

Thanks to @tcheinen for having a first shot at this issue.

cryhot added 2 commits May 23, 2021 07:16
Remove duplicate `_retry_with_backoff` call.
When the imported event contains a UID field, update the event instead of creating a duplicate.
@MarkoSchuetz
Copy link
Copy Markdown

What is keeping this from being merged?

@cryhot
Copy link
Copy Markdown
Author

cryhot commented Oct 20, 2021

Some function has been renamed, I've updated it in my branch, all conflicts should be resolved now.

@vincesherman
Copy link
Copy Markdown

This is a great solution; currently I import my 'work' calendar into my google calendar by importing an ICS daily, and manage duplicates by deleting everything from my google calendar before importing the ICS.

@yarikoptic
Copy link
Copy Markdown
Contributor

This is promising! I just was informed that I had caused a large group of ppl getting duplicate notifications since my calendar got all them as guests on my "copy" of an event which I had imported twice (was updated). I guess this solution could have prevented it (didn't try yet).

@insanum - any chance you could have a look and provide feedback and/or merge?

@dbarnett
Copy link
Copy Markdown
Collaborator

Hello from 2024! This change no longer merges cleanly, but I put together an updated PR #712 based on this change that should fix these issues. Would anyone be able to give that version a try and make sure it's not horribly broken so I can finally merge a fix for this? =)

@dbarnett dbarnett closed this Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants