Skip to content

Conversation

@Propfend
Copy link
Contributor

@Propfend Propfend commented Dec 4, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 4, 2025 19:31
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for building the project with CUDA and Vulkan feature flags through new Makefile targets and corresponding build pipeline configurations.

Key Changes:

  • Added two new worker scripts to execute cargo builds with CUDA and Vulkan features
  • Modified the release script to conditionally select build configurations based on command-line flags
  • Added convenience Makefile targets for CUDA and Vulkan release builds

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
jarmuz/worker-cargo-build-release-vulkan.mjs New worker script that builds with Vulkan and web_admin_panel features
jarmuz/worker-cargo-build-release-cuda.mjs New worker script that builds with CUDA and web_admin_panel features
jarmuz-release.mjs Modified to dynamically select build configuration based on --cuda or --vulkan flags
Makefile Added release.cuda and release.vulkan targets for building with respective features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +9 to +11
"cargo-build-release" +
(process.argv.includes("--cuda") ? "-cuda" : "") +
(process.argv.includes("--vulkan") ? "-vulkan" : ""),
Copy link

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current logic allows both --cuda and --vulkan flags to be combined (e.g., 'cargo-build-release-cuda-vulkan'), but there are no corresponding worker files for this combination. Either create a worker file for the combined case, or add validation to ensure only one flag is specified at a time.

Copilot uses AI. Check for mistakes.
@mcharytoniuk mcharytoniuk merged commit 62106dd into intentee:main Dec 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants