Skip to content

Ensure current unit tests pass on CI under Python 2.7 #23

@hornc

Description

@hornc

Commit b8831c7 removed the existing tests from running on CI, which enabled a parse error to slip into master, involving a try with a missing except block which is fixed by #20

After some discussion (amongst archive.org staff and volunteers) we agreed the following:

Therefore we need to upgrade this internetarchive/infogami fork to Python 3 to support Open Library.

To do this safely since this codebase has had had much activity for a long time, we need to have confidence that we are not breaking anything in our fork with current changes.

  • Get existing unit tests running and passing on CI under Python2.7 to provide a baseline for our fork (run under Python 3 for information only, in allowed failures)
  • Get flake8 tests passing under Python 2.7
  • Focus on fixing Python 3 failures, move this out of allowed failures

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions