forked from infogami/infogami
-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Description
Commit b8831c7 removed the existing tests from running on CI, which enabled a parse error to slip into master, involving a try with a missing except block which is fixed by #20
After some discussion (amongst archive.org staff and volunteers) we agreed the following:
- We need this repo for the continued functioning of the Open Library project https://github.com/internetarchive/openlibrary
- We have committed to making the Open Library codebase Python 3 compatible due to the impending Python 2 EOL
Therefore we need to upgrade this internetarchive/infogami fork to Python 3 to support Open Library.
To do this safely since this codebase has had had much activity for a long time, we need to have confidence that we are not breaking anything in our fork with current changes.
- Get existing unit tests running and passing on CI under Python2.7 to provide a baseline for our fork (run under Python 3 for information only, in allowed failures)
- Get flake8 tests passing under Python 2.7
- Focus on fixing Python 3 failures, move this out of allowed failures
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels