Refix threadeddict #10341

[mekarpeles]

Merge + vbump first: internetarchive/infogami#225

Closes #10341

guard against web.ctx.features, not just web.ctx

Technical

Testing

Screenshot

Stakeholders

[mekarpeles]

This isn't a complete solution because in the else statement, the render_template is still hitting infogami and checking debug

[cdrini]

Figured out a fix! Switching to context.features instead of web.ctx.features ; that did the trick!

Confusingly, it seems like sometimes (??) the loadhook for setting things up isn't called. Not sure why. It does seem like this bit is called:

openlibrary/openlibrary/plugins/openlibrary/code.py

Lines 1388 to 1391 in 2bbd085

	def setup_context_defaults():
	from infogami.utils import context
	context.defaults.update({'features': [], 'user': None, 'MAX_VISIBLE_BOOKS': 5})

Which is giving the features a default, but only on context not web.ctx , which is why the fix worked.

Anyways, problem solved 😄 We'll have to get to the root cause of this at another time.