Remove history table from book and author pages#12092
Remove history table from book and author pages#12092mekarpeles merged 4 commits intointernetarchive:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes the inline “History” preview table from edition and author pages so users rely on the existing “History” link in the page databar, reducing render cost and eliminating the .json/.rdf direct-link section that was part of the history template.
Changes:
- Removed
lib/historyrendering (and its profiling timer) from the edition page template. - Removed
lib/historyrendering from the author page template and added a standalone.clearfixto preserve layout.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| openlibrary/templates/type/edition/view.html | Drops History table render block and associated timing measurement from edition view. |
| openlibrary/templates/type/author/view.html | Replaces History table render with a .clearfix div to prevent layout breakage. |
You can also share your feedback on Copilot code review. Take the survey.
|
Why not just edit the history table template to remove the unwanted information and leave the rest, perhaps renaming it more appropriately if you're ambitious? In addition to RDF & JSON, some pages also have OPDS and Wikipedia citation links. |
github-actions
bot
added
the
Needs: Response
|
I do agree with @tfmorris that https://github.com/internetarchive/openlibrary/blob/606ba88a13f96de264d250de16b9b616f5908493/openlibrary/templates/lib/history.html#L30C1-L64C23 (i.e. export options which doesn't even seem related to history) likely deserves to remain on the page; maybe we can move it into its own sub template. |
mekarpeles
added
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
for more information, see https://pre-commit.ci
* Remove history table from book and author pages * split page exports and history modules --------- Co-authored-by: Mek <michael.karpeles@gmail.com>
Closes #12074
Closes #12082
Removes history table from work, edition, and author pages. Historical edits on these records can be seen by clicking the "History" link that is found next to the "Edit" button.
The direct links to
.jsonand.rdfrecords are a part of the history table template, and will also no longer be rendered on these pages. As of writing, there are about 440K.rdfrequests in our nginx access logs.Technical
The author page's styling breaks horribly without the
.clearfixdiv, which is a part of the history table template.To prevent this, the author page history table has been replaced by a
.clearfixdiv.Testing
Screenshot
Stakeholders
Author page -- short list of authored books.
Book page.