Skip to content

Remove legacy-header.css and dead header selectors#12108

Merged
cdrini merged 1 commit intointernetarchive:masterfrom
lokesh:legacy-css
Mar 20, 2026
Merged

Remove legacy-header.css and dead header selectors#12108
cdrini merged 1 commit intointernetarchive:masterfrom
lokesh:legacy-css

Conversation

@lokesh
Copy link
Copy Markdown
Collaborator

@lokesh lokesh commented Mar 17, 2026

The old header (div#header, #headerNav, #headerLogo, etc.) was replaced by .header-bar years ago. No HTML template references these IDs anymore.

  • Delete legacy-header.css (168 lines)
  • Remove its @import from legacy.css
  • Remove dead #header* overrides from page-admin, page-edit, page-plain, and page-user CSS entry points

Technical

Testing

Make sure header renders correctly.

Screenshot

No change:

image

Stakeholders

@jimchamp @cdrini

The old header (div#header, #headerNav, #headerLogo, etc.) was replaced
by .header-bar years ago. No HTML template references these IDs anymore.

- Delete legacy-header.css (168 lines)
- Remove its @import from legacy.css
- Remove dead #header* overrides from page-admin, page-edit, page-plain,
  and page-user CSS entry points

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@lokesh lokesh requested a review from RayBB March 17, 2026 06:21
Copy link
Copy Markdown
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm ; flipped around site everything looked normal.

@cdrini cdrini merged commit 68d8b8e into internetarchive:master Mar 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants