Add some types to OLConnection#12113
Open
cdrini wants to merge 1 commit intointernetarchive:masterfrom
Open
Conversation
github-project-automation
bot
moved this to Waiting Review/Merge from Staff
in Ray's Project
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Python type annotations around the Open Library infobase connection factory and related connection wrappers to reduce ambiguity when tracing the DB connection pathway.
Changes:
- Added type hints to
ConnectionMiddleware.__init__andHybridConnection.__init__. - Refactored
OLConnectionto inline the connection-selection logic and added return typing pluscast(...)for local/remote connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor. While investigating the db pathway added some types to clear up ambiguities.
Technical
Testing
Screenshot
Stakeholders