fix flake8 errors due to new pypi dependency/rule updates#597
Merged
imatiach-msft merged 1 commit intointerpretml:mainfrom May 31, 2024
Merged
Conversation
imatiach-msft
force-pushed
the
ilmat/fix-flake8-errors
branch
11 times, most recently
from
a5f3250 to
2edf08b
Compare
imatiach-msft
force-pushed
the
ilmat/fix-flake8-errors
branch
from
2edf08b to
671a8c5
Compare
tongyu-microsoft
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix new flake8 errors that started to appear in gated builds after new versions of flake8 helper packages were released with new rules.
Specifically, I believe these are from flake8-bugbear and flake8-pytest-style updates.
Also temporarily pin scikit-learn<=1.4.2 due to issue with econml and scikit-learn in tests when validating ExplanationDashboard visualization from raiwidgets package.
Copilot summary:
This pull request primarily involves syntax modifications across several Python test files. The most significant changes include the addition of a specific error code to a
BaseExceptioningpu_kmeans.py, and the removal of parentheses from several pytest decorators inconftest.pyandtest_notebooks.py.Here are the key changes:
Syntax modifications:
python/interpret_community/common/gpu_kmeans.py: Added a specific error code to theBaseExceptionto adhere to linting rules.tests/conftest.py: Removed parentheses from thepytest.fixturedecorator, which is a more Pythonic style.tests/test_notebooks.py: Removed parentheses from thepytest.mark.notebooksdecorator in multiple test methods. This change was made consistently across several methods to maintain a uniform coding style. [1] [2] [3] [4] [5] [6] [7]