parsers: lines: display "ignoring (...)" for all unrecognized lines#460
Merged
bosd merged 1 commit intoinvoice-x:masterfrom Feb 5, 2023
Merged
Conversation
Collaborator
rmilecki
commented
Feb 3, 2023
rmilecki
commented
This is very helpful for debugging problems with parsing lines. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Collaborator
Author
|
This addresses: This diff looks quite big, but the real change is To review this pull request easily please use |
Collaborator
Author
|
See actual changes in this pull request: |
bosd
approved these changes
Feb 4, 2023
Collaborator
bosd
left a comment
bosd
left a comment
There was a problem hiding this comment.
Was afraid this would affect the results.
Tests are still passing, so LGTM
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.