loader: require .json extension and allow .yaml extension#520
Merged
bosd merged 2 commits intoinvoice-x:masterfrom Nov 2, 2023
Merged
loader: require .json extension and allow .yaml extension#520bosd merged 2 commits intoinvoice-x:masterfrom
bosd merged 2 commits intoinvoice-x:masterfrom
Conversation
Collaborator
rmilecki
commented
Aug 6, 2023
Collaborator
|
Thanks for this PR. I think adding more extension filters will block the possibility to streamload templates even further. |
added 2 commits
November 2, 2023 19:10
Trying to parse every file other than *.yml as JSON file isn't the best idea. It wastes time on trying to parse non-template files. It produces warnings like "json Loader Failed to load (...)template" for files that were never meant to be templates. It's a bad pracice in general. Check for file extension before using json.loads(). Fixes: 0d2d16c ("Native JSON Template Support") Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Oficially suggested extension for YAML files is .yaml. Accept it. Link: https://yaml.org/faq.html Fixes: invoice-x#514 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
7beb0be to
18015ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.