(ipld-prime) Use mh.Set() for "hash" -> mhType & Make git plugin test work again#8287
Merged
rvagg merged 6 commits intofeat/dag-put-ipld-primefrom Jul 23, 2021
Merged
Conversation
3 tasks
Member
Author
|
Noice, Circle giving green now for sharness |
mvdan
reviewed
Jul 21, 2021
fdc7245 to
07c3b2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mvdan this extends your last commit to the branch to do
mh.Set()forhashas well.It also revives t0280 for the git-plugin. The diff with master is the most interesting bit now:
Note the pathing through the git object at the bottom there. I wouldn't mind getting that addressed - don't CamelCase, at least one rename, and maybe turn those arrays into maps so we can do it by name. It'd be nice to maintain consistency of forms.