Use traitlets>=4.1 APIs #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainCorlay
force-pushed
the
update_traitlets
branch
3 times, most recently
from
de37e57 to
c9dd1ed
Compare
Member
Author
|
@takluyver there will be less deprecation warnings! |
| def init_metadata(self, parent): | ||
| """Initialize metadata. | ||
Member
There was a problem hiding this comment.
You know what we say about whitespace changes ;-)
Member
Author
There was a problem hiding this comment.
Yeah but there are good whitespace changes and bad whitespace changes... ;) (these are good)
Member
|
A few comments inline, but I only care about the traitlets 4.2 question before merging. |
SylvainCorlay
force-pushed
the
update_traitlets
branch
from
c9dd1ed to
0a615d3
Compare
Member
Author
|
@minrk I updated / squashed as per your comments. |
Member
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_foo_changed->@observe('foo')+ signature change._bar_default->@default('bar')