Allow pyside2 gui loop #399
Conversation
|
Sad that this gets ignored completely. |
|
@ccordoba12 does this change look reasonable to you? |
|
@bergtholdt please understand that we are volunteers and not all of us are equally familiar with the code base. |
| """Start a kernel with PyQt5 event loop integration.""" | ||
| os.environ['QT_API'] = 'pyqt5' | ||
| if os.environ['QT_API'] not in ['pyqt5', 'pyside2']: | ||
| os.environ['QT_API'] = 'pyqt5' |
There was a problem hiding this comment.
I really don't understand this change. I mean, this
if os.environ['QT_API']
assumes that QT_API is already in the environment, which is not always the case.
And this
not in ['pyqt5', 'pyside2']
seems to assume that the only possible values of QT_API can be pyqt5 and pyside2, when they can also be pyqt and pyside.
|
@ccordoba12 yes, exactly! I asked the same thing in the original Issue #398 referenced at the top, which did not receive any comments. @blink1073 please understand that I am also a volunteer myself and try to push fixes in my codebase to the central repository so others may benefit. Being ignored for 5 months just kills any motivation in going the extra mile to submit issues and provide pull requests. |
|
I removed the offending line completely os.environ['QT_API'] = 'pyqt5'In another pull request #444 I did not find any issues in qtconsole with the qt5 gui integration and matplotlib. |
4 participants
Fixes #398