Skip to content

Allow pyside2 gui loop #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivanov merged 4 commits into from
Dec 3, 2021
Merged

Allow pyside2 gui loop #444

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
445153c
Allow pyside2 gui loop
bergtholdt Apr 11, 2019
17caf99
set default python bindings
bergtholdt Oct 14, 2019
34ea83c
FIX: set appropriate QT_API, defaulting to pyqt5 with pyside2 as fall…
bergtholdt Oct 17, 2019
2d15ed6
keep with previous behavior
ivanov Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ipykernel/eventloops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,16 @@ def loop_qt4(kernel):
@register_integration('qt', 'qt5')
def loop_qt5(kernel):
"""Start a kernel with PyQt5 event loop integration."""
os.environ['QT_API'] = 'pyqt5'
Copy link
Member

@ccordoba12 ccordoba12 Oct 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not set, then there's no way to select the right Python bindings to create the event loop (unless users set QT_API by hand).

Therefore, I'm -1 on this one.

Copy link
Contributor Author

@bergtholdt bergtholdt Oct 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, changed it to set if unset. This also prevents it from being overwritten in every loop (as it was originally).

if os.environ.get('QT_API', None) is None:
try:
import PyQt5
os.environ['QT_API'] = 'pyqt5'
except ImportError:
try:
import PySide2
os.environ['QT_API'] = 'pyside2'
except ImportError:
os.environ['QT_API'] = 'pyqt5'
return loop_qt4(kernel)


Expand Down