Merged
Conversation
irgaly
commented
Apr 13, 2023
| // イベント送信漏れが発生しないように SUSPEND | ||
| onBufferOverflow = BufferOverflow.SUSPEND | ||
| ) | ||
| private val lastEvent = source.map { |
Owner
Author
There was a problem hiding this comment.
map { } は、Dispatcher の都合により遅延実行されることがあり、テストでイベントの発行が重複することがあった。
irgaly
commented
Apr 13, 2023
| it.eventType shouldBe KottageEventType.Create | ||
| cache.eventFlow().let { flow -> | ||
| flow.test { | ||
| flow.ensureSubscribed() |
Owner
Author
There was a problem hiding this comment.
KottageEventFlow は subscribe 完了まで短い時間 suspend されることがある。
Turbine は subscribe での suspend を待たないため、ensureSubscribed() で待てるようにした。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux Event Test が Coroutine のタイミングで数回に1回程度失敗することがあった。