Conversation
ganler
left a comment
There was a problem hiding this comment.
Thanks for the contribution!!! In addition to those minor issues, would you also help add a dtype_test for tensorflow? Like https://github.com/ise-uiuc/nnsmith/blob/main/tests/torch/test_trt_backend.py#L56
|
Would you mind if I prioritize merging #41 as it alignes with an alpha release? I can help you sync this PR with latest branch. |
Sure. You can merge that, and I will sync with the latest main branch. |
|
The conv2d spec should be fixed. TF's padding mechanism is quite different from torch. See https://www.tensorflow.org/api_docs/python/tf/nn#notes_on_padding_2 |
|
There are still a few things to fix later:
|
No description provided.