Fix Duplicate Icons and Splashes#15
Merged
alexblom merged 5 commits intoMar 23, 2017
Merged
Conversation
…ld be the case in the outputted XML Fixes an issue in the update config util where the XML width and height are string but this function returns width and height as integers.
… not be replaced
This bug manifested itself by adding icon and splash nodes on each
`ember cordova:make-icons` run.
Introduces a bug where an icon for the iOS `icon-40@3x` size is not
generated because comparing using an attrs hash fails because the
`icon-60@2x` has the same attrs hash: `{ width: '120' }`.
Fixes a bug where an icon for the iOS `icon-40@3x` size was not being
generated because comparing using an attrs hash fails because the
`icon-60@2x` has the same attrs hash: `{ width: '120' }`.
Also adds missing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/isleofcode/ember-cordova/issues/217.