Skip to content

run with node20#47

Merged
ncalteen merged 1 commit intoissue-ops:mainfrom
bmos:patch-1
Mar 5, 2024
Merged

run with node20#47
ncalteen merged 1 commit intoissue-ops:mainfrom
bmos:patch-1

Conversation

@bmos
Copy link
Copy Markdown

@bmos bmos commented Mar 5, 2024

No description provided.

@bmos bmos requested a review from a team as a code owner March 5, 2024 23:46
@bmos bmos marked this pull request as draft March 5, 2024 23:49
@ncalteen
Copy link
Copy Markdown
Contributor

ncalteen commented Mar 5, 2024

Thanks for the PR! Looks good to me. CI is failing be wise of permissions for forked workflow runs, not anything wrong with your change :)

@bmos bmos marked this pull request as ready for review March 5, 2024 23:54
@ncalteen ncalteen self-assigned this Mar 5, 2024
@bmos
Copy link
Copy Markdown
Author

bmos commented Mar 5, 2024

Thanks for that clarity, I was just reading the documentation for the action that failed.
Looks like you can break that file into two parts and it will behave nicer on PRs.
https://github.com/dorny/test-reporter?tab=readme-ov-file#recommended-setup-for-public-repositories

@ncalteen ncalteen merged commit 832835d into issue-ops:main Mar 5, 2024
@ncalteen
Copy link
Copy Markdown
Contributor

ncalteen commented Mar 5, 2024

Thanks for pointing that out! I will have to update this and the other repos in the org :)

@bmos bmos deleted the patch-1 branch March 5, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants