Backup and restore the viewport size when rendering sliders#108
Backup and restore the viewport size when rendering sliders#108itdelatrisu merged 2 commits intoitdelatrisu:masterfrom
Conversation
|
uh, wait one sec, there's a small error |
…ecause Slick tends to allocate offscreen buffers for itself only with power of two textures, so it will use another viewport when rendering to its own offscreen buffers.
|
Alright, that should be it. I should really always do a complete diff before making a pull-request |
|
Thanks! It doesn't seem to completely fix the issue for me, though: |
|
what's the beatmap? |
|
221216 (hard) |
|
I'm pretty sure you told me like twice already but what was your GPU again? Just asking because this doesn't happen with my Nvidia gpu, gonna try on my intel gpu next |
|
Playing at 1440x900, if that matters. |
|
Alright, I can reproduce it with my Intel card now. I'll take a look at it tomorrow |
|
Awesome, thank you! |
This doesn't actually make a difference in functionality. The issue is that the flashlight mod uses Slicks FBO functions which use the EXT version and Intel drivers generate the same FBO IDs twice if the EXT and ARB versions are mixed.
|
Turns out the Intel drivers return the same FBO id twice if the ARB and EXT versions of framebuffers are used. And the flashlight mod calls Slick methods that use the EXT version, so I needed to use those (the only other alternatives would have been some ugly hacks). This should remedy the situation and fix #107 in its entirety. |
|
Perfect. Thanks again! |
Backup and restore the viewport size when rendering sliders
Set minimum OpenGL version for mmsliders to 3.0 (from 3.2) and removed an unused variable. Signed-off-by: Jeffrey Han <itdelatrisu@gmail.com>
2 participants
Backup and restore the viewport size when rendering sliders. Needed because Slick tends to allocate offscreen buffers for itself only with power of two textures, so it will use another viewport when rendering to its own offscreen buffers.
Should fix #107