Add catch clause for UnsupportedAudioFileException and fix LineUnavailableExceptions #371
Merged
itdelatrisu merged 2 commits intoitdelatrisu:masterfrom Mar 10, 2018
Merged
Conversation
May fix Linux audio issues due to opening multiple lines with the same format.
Distinguishes between specific audio errors (such as unreadable audio files) and more general errors (such as unavailable decoders for the audio type).
Owner
|
Thanks! Will merge since it seems harmless enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Needs more testing on other setups.
Adds more details with issues regarding sound file loading and possibly fix the Linux side of
LineUnavailableExceptions.Has been tested on Windows (
Windows 10 x64) and Linux (Mint Cinnamon 18.3 x64) with no ill effects.Changes:
Don't open a line with the same format twice (as found in this StackOverflow post)
Add an additional catch clause for
UnsupportedAudioFileExceptionto better distinguish audio file-specific errors (such as corrupted files) and more general errors (such as non-present decoders for an audio type)