Fixed stack leniency calculations#406
Conversation
tpenguinltg
left a comment
tpenguinltg
left a comment
There was a problem hiding this comment.
I haven't tested this yet, but code-wise, I think it's fine apart from the few minor things I pointed out.
| private void calculateStacks() { | ||
| // reverse pass for stack calculation | ||
| for (int i = gameObjects.length - 1; i > 0; i--) { | ||
|
|
| } | ||
| } | ||
| } | ||
|
|
| continue; | ||
|
|
||
| // check if in range stack calculation | ||
| float timeI = hitObjectI.getTime() - (approachTime * beatmap.stackLeniency); |
There was a problem hiding this comment.
Parentheses around approachTime * beatmap.stackLeniency can be removed as * has precedence over -.
There was a problem hiding this comment.
I was basing on the code that was before that had parenthesis
There was a problem hiding this comment.
Ah, then I would have kept it the way you had it, but it seems I didn't reply soon enough. Oh well, it's done now, so let's see if @itdelatrisu cares much about it.
| hitObjectI = hitObjectN; | ||
| } | ||
| } | ||
| } else if (hitObjectI.isSlider()) { |
There was a problem hiding this comment.
Do we care about the case where the hit object is not a circle or slider (e.g. when it's a spinner)? If so, should we be doing anything with it in an else clause?
|
I can't request a review (i don't know why), so summon @itdelatrisu |
2 participants
Fixes the first part of #401 issue. Stack leniency calculations were wrong for sliders, which were clearly visible on some 2B maps, such as "Mayday" or "Endless Tewi-ma Park."