Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new list commands (
LGETandLLEN) and replaces the set commandSMEMBERSwithSGETthroughout the codebase. The changes include updates to the command handlers, tests, documentation, and command whitelisting to support these new and renamed commands.List command enhancements:
lgetHandlerandllengHandlerfunctions tointernal/db/db.goto implement the newLGET(get all list elements) andLLEN(get list length) commands.LGETandLLENin theCommandsmap ininternal/db/db.goso they are available in the REPL and scripts.internal/db/db_test.goto cover the new list commands and their edge cases.Set command renaming:
smembersHandlerfunction withsgetHandlerand updated its usage throughout the codebase, including command registration, tests, and snapshot logic. [1] [2] [3]Documentation and help updates:
readme.mdto document the newLGET,LLEN, andSGETcommands and removed references to the oldSMEMBERScommand. [1] [2]internal/repl/repl.goto reflect the new and renamed commands.Script command whitelisting:
LGET,LLEN, andSGETto the script command whitelist ininternal/script/script.goto allow their usage in scripts.Cleanup:
furr/internal/handlersfromcmd/furrdb/main.go.