Add option to disable easy to abuse API endpoints#5630
Draft
Fijxu wants to merge 1 commit intoiv-org:masterfrom
Draft
Add option to disable easy to abuse API endpoints#5630Fijxu wants to merge 1 commit intoiv-org:masterfrom
Fijxu wants to merge 1 commit intoiv-org:masterfrom
Conversation
The API endpoints that will be disabled when this option are: - /api/v1/videos - /api/v1/clips - /api/v1/transcripts There is still API endponts that need some sort of validation or connection/proxying to Invidious companion like `/api/v1/captions` and `/api/v1/storyboards` since they also do a video request to Invidious companion. I'm not sure if the `/next` API endpoint could be used to gather that type of information, if so, that would be better. Closes iv-org#5599
| ## Accepted values: true, false | ||
| ## Default: false | ||
| ## | ||
| disable_api: false |
Contributor
There was a problem hiding this comment.
Imo the key name should also make it clear that it's only easily abused API endpoints that are disabled (like the comment does)
Maybe disable_abusable_api (like how the handler is named)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #5628
The API endpoints that will be disabled when this option are:
Add a
disable_apiconfig option, although it could be changed to a more flexible option to let the instance owner disable the API endpoints they want to disable, but I'm not too sure, what do you think @unixfox?There is still API endponts that need some sort of validation or connection/proxying to Invidious companion like
/api/v1/captionsand/api/v1/storyboardssince they also do a video request to Invidious companion. I'm not sure if the/nextAPI endpoint could be used to gather that type of information, if so, that would be better.Closes #5599