Encapsulate translation constants and functions inside it's own I18n module#5637
Merged
Fijxu merged 1 commit intoiv-org:masterfrom Apr 25, 2026
Merged
Conversation
Fijxu
added
the
type:i18n/l10n
Member
Author
|
Also, I wonder, should be adhere to the naming the modules have across most of the codebase? Which is appending |
SamantazFox
approved these changes
Feb 26, 2026
Fijxu
force-pushed
the
translation-module-encapsulation
branch
from
c148cef to
0d20db2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, it encapsulates all related code from translation into it's own module.
Required for the migration to the crystal stdlib logger: #5426