1. ignoring @eaDir directories 2. setting UID and GID of copy / move process#213
Open
nigelpatsmith wants to merge 1 commit intoivandokov:masterfrom
Open
1. ignoring @eaDir directories 2. setting UID and GID of copy / move process#213nigelpatsmith wants to merge 1 commit intoivandokov:masterfrom
nigelpatsmith wants to merge 1 commit intoivandokov:masterfrom
Conversation
ivandokov
requested changes
Nov 13, 2023
Owner
There was a problem hiding this comment.
Can you please add a test that checks if @eaDir is actually ignored. Add the directory in tests/input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use a synology NAS and the @eadir directories were causing problems, so the updates to phockup.py ignore the directories, and form the base of being able to ignore more directories in the future.
I also wanted the move to use the right permissions, so entrypoint.sh does an su to the user, and there's two new env variables: PHOCKUP_UID and PHOCKUP_GID