Skip to content

Add keyword arguments for str.split (resolves j-andrews7/kenpompy#27) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-andrews7 merged 1 commit into from
Oct 11, 2022
Merged

Add keyword arguments for str.split (resolves j-andrews7/kenpompy#27) #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kenpompy/summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ def get_playerstats(browser, season=None, metric='EFG', conf=None, conf_only=Fal

# Split ortg column.
ps_df.columns = ['Rank', 'Player', 'Team', 'ORtg', 'Ht', 'Wt', 'Yr']
ps_df[['ORtg', 'Poss%']] = ps_df['ORtg'].str.split(' ', 1, expand=True)
ps_df[['ORtg', 'Poss%']] = ps_df['ORtg'].str.split(' ', n=1, expand=True)
ps_df['Poss%'] = ps_df['Poss%'].str.strip('()')

ps_df = ps_df[ps_df.Rank != 'Rk']
Expand Down Expand Up @@ -422,7 +422,7 @@ def get_kpoy(browser, season=None):

# Some mildly moronic dataframe tidying.
kpoy_df[['Player', 'Weight', 'Year', 'Hometown']] = kpoy_df['Player'].str.split(' · ', expand=True)
kpoy_df[['Player', 'Info']] = kpoy_df['Player'].str.split(', ', 1, expand=True)
kpoy_df[['Player', 'Info']] = kpoy_df['Player'].str.split(', ', n=1, expand=True)
kpoy_df['Team'] = kpoy_df['Info'].str.replace(r'\d+', '', regex=True).str.rstrip('-')
kpoy_df['Height'] = kpoy_df['Info'].str.replace(r'[a-z]+', '', flags=re.IGNORECASE, regex=True).str.strip('. ').str.strip()
kpoy_df = kpoy_df.drop(['Info'], axis=1)
Expand All @@ -438,7 +438,7 @@ def get_kpoy(browser, season=None):

# More tidying.
mvp_df[['Player', 'Weight', 'Year', 'Hometown']] = mvp_df['Player'].str.split(' · ', expand=True)
mvp_df[['Player', 'Info']] = mvp_df['Player'].str.split(', ', 1, expand=True)
mvp_df[['Player', 'Info']] = mvp_df['Player'].str.split(', ', n=1, expand=True)
mvp_df['Team'] = mvp_df['Info'].str.replace(r'\d+', '', regex=True).str.rstrip('-')
mvp_df['Height'] = mvp_df['Info'].str.replace(r'[a-z]+', '', flags=re.IGNORECASE, regex=True).str.strip('. ').str.strip()
mvp_df = mvp_df.drop(['Info'], axis=1)
Expand Down