Fix for ambiguous column names in DataFrame returned by get_pomeroy_ratings#34
Merged
Fix for ambiguous column names in DataFrame returned by get_pomeroy_ratings#34
Conversation
j-andrews7
approved these changes
Nov 11, 2022
Owner
j-andrews7
left a comment
j-andrews7
left a comment
There was a problem hiding this comment.
I think this is fine. Breaking stuff is a-okay with me, that's what versioning is for.
Collaborator
Author
|
Great! Thanks for the guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the DataFrame returned by
kenpompy.misc.get_pomeroy_ratings()has several columns which share the same name. Needless to say, this can make it difficult to parse which column refers to which specific piece of data at first glance, and difficult to reference the specific column one might be after.This PR introduces explicitly-prescribed column names to the returned DataFrame to alleviate this.
@j-andrews7 Wanted to run this change by you and get your thoughts before merging into the working branch, since it's a potentially breaking change.