Skip to content

Update to test_get_program_ratings to use dynamic verification of df shape#54

Merged
esqew merged 1 commit intomasterfrom
fix/test_get_program_ratings_shape_calc
Oct 19, 2023
Merged

Update to test_get_program_ratings to use dynamic verification of df shape#54
esqew merged 1 commit intomasterfrom
fix/test_get_program_ratings_shape_calc

Conversation

@esqew
Copy link
Collaborator

@esqew esqew commented Jul 14, 2023

Ensures we don't have to update the tuple literal annually by instead performing the verification based on the number of table rows bs4 returns. This way, the test still ensures that the logic applied for casting the program ratings table to a DataFrame doesn't include/exclude anything erroneous.

…ape to preclude annual updates to tuple literal
@esqew esqew added the enhancement New feature or request label Jul 14, 2023
@esqew esqew self-assigned this Jul 14, 2023
@esqew esqew merged commit 766f9f8 into master Oct 19, 2023
@esqew esqew deleted the fix/test_get_program_ratings_shape_calc branch October 19, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant