Skip to content

Fixed team schedules before 2010#75

Merged
j-andrews7 merged 2 commits intoj-andrews7:masterfrom
WakeUpWaffles:master
Nov 22, 2023
Merged

Fixed team schedules before 2010#75
j-andrews7 merged 2 commits intoj-andrews7:masterfrom
WakeUpWaffles:master

Conversation

@WakeUpWaffles
Copy link
Contributor

Originally was looking into #68, but seems to all ready be handled after creating tests. It is handled by this code:

if team==None or team not in get_valid_teams(browser, season):
raise ValueError(
'the team does not exist in kenpom in the given year. Check that the spelling matches (https://kenpom.com) exactly.')

However, I found an issue with team's schedules not having a rank column 2010 and earlier. Added logic to handle the missing column.

test_team.py test coverage now includes:

  • Teams with no data for a given year
  • Incorrect team names
  • Team's schedule 2010 and before

- Teams with no data for a given year
- Incorrect team names
@WakeUpWaffles WakeUpWaffles changed the title Added Tests to test_team.py Fixed team schedules before 2010 Nov 3, 2023
@j-andrews7
Copy link
Owner

Yeah, seems like a good idea. I will try to roll all the PRs in by the end of the week to get a release out to fix most of the outstanding issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants