Fixed team schedules before 2010#75
Merged
j-andrews7 merged 2 commits intoj-andrews7:masterfrom Nov 22, 2023
Merged
Conversation
- Teams with no data for a given year - Incorrect team names
Added more unit tests
Owner
|
Yeah, seems like a good idea. I will try to roll all the PRs in by the end of the week to get a release out to fix most of the outstanding issues. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally was looking into #68, but seems to all ready be handled after creating tests. It is handled by this code:
kenpompy/kenpompy/team.py
Lines 74 to 77 in a30590b
However, I found an issue with team's schedules not having a rank column 2010 and earlier. Added logic to handle the missing column.
test_team.py test coverage now includes: