Make sure every process tree is using unique shared memory.#30
Draft
ndmitchell wants to merge 1 commit intojacereda:masterfrom
Draft
Make sure every process tree is using unique shared memory.#30ndmitchell wants to merge 1 commit intojacereda:masterfrom
ndmitchell wants to merge 1 commit intojacereda:masterfrom
Conversation
Owner
|
I have always considered the "-" output to be a debug-only flag. The caller should provide unique output filenames. Is this for the test suite? |
Contributor
Author
|
It's not required by the test suite, but would be if we ever ran it in parallel. I have no strong practical need for this to be fixed. However the spooky action at a distance aspect of the bug was deeply confusing when I encountered it by accident, and it could recur if two people used log.txt in different directories with a relative path (I think) so tempted to say if the fix is easy enough it might be worth it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment if you run
fsatrace rwm - -- some commandtwice in parallel then they end up sharing a buffer and results from both get shared. I have solved this in the patch below by making a unique shared memory buffer for each by addingGetTickCountinto the name. I have marked this PR draft because it only works on Windows, so you will want to do something slightly different.I couldn't find a good source of unique data in a portable way. The high resolution C time functions are not available on MingW, and the 1 second
time()is insufficient (both in theory and testing). One option is to make it an#ifdef, or maybe you know of a suitable random source.