Add support for Lua code blocks#132
Merged
Merged
Conversation
Owner
|
Thanks for the PR, I plan on reviewing/testing this week. |
Owner
|
Hey there, I haven't forgotten this.. just been busy. Before I approve and merge this, I need to fix CI and hope to do so this weekend. In the meantime, can you add a Lua code block example to the README like I did in this PR ? If not, no worries.. I can do that post-merge. |
| .success(); | ||
| } | ||
|
|
||
| #[test] |
Owner
There was a problem hiding this comment.
Just 2 changes to get Lua running under GH Actions CI
- Above this line, add this:
#[cfg(target_os = "linux")] - Update
ci.ymlto match my changes here: https://github.com/jacobdeichert/mask/compare/test-lua-runtime
After that, I'll approve and merge!
Owner
There was a problem hiding this comment.
Also please pull in latest from master. I fixed CI so your PR should pass after all of these changes are in place.
jacobdeichert
approved these changes
Jan 10, 2026
Owner
jacobdeichert
left a comment
jacobdeichert
left a comment
There was a problem hiding this comment.
Looks great, thanks for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this fix?
Closes #131
Describe the solution
Added a new executor for
lua, taking from therubyexecutor.