Skip to content

Convert VerticalResizer.tsx from class component to functional component #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yurishkuro merged 6 commits into from
Aug 20, 2025
Merged

Convert VerticalResizer.tsx from class component to functional component #2951

yurishkuro merged 6 commits into from
Aug 20, 2025

Conversation

@Parship999
Copy link

@Parship999 Parship999 commented Jul 9, 2025 •
edited
Loading

Which problem is this PR solving?

Description of the changes

  • Converted the following component to functional component: VerticalResizer.tsx

Checklist

verticalresizer-to-functional
4591dc5 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 requested a review from a team as a code owner July 9, 2025 10:07
@Parship999 Parship999 requested review from pavolloffay and removed request for a team July 9, 2025 10:07
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 9, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

minor fix
1735dbe 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@codecov
Copy link

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (56c2d82) to head (349eb1d).
⚠️ Report is 76 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2951      +/-   ##
==========================================
+ Coverage   97.76%   98.13%   +0.37%     
==========================================
  Files         256      257       +1     
  Lines        7969     8006      +37     
  Branches     2008     2091      +83     
==========================================
+ Hits         7791     7857      +66     
+ Misses        178      149      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Parship Chowdhury added 2 commits July 9, 2025 10:27
minor fix 2
6f4f13d 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
minor fix 3
b903744 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
graphite-app[bot]
graphite-app bot reviewed Jul 9, 2025
View reviewed changes
minor fix 4
52cc132 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Jul 10, 2025
@yurishkuro yurishkuro requested review from vishvamsinh28 and removed request for pavolloffay July 10, 2025 01:44
@Parship999
Copy link
Author

Parship999 commented Jul 31, 2025

@vishvamsinh28 can you please review this PR?

yurishkuro
yurishkuro reviewed Aug 2, 2025
View reviewed changes
packages/jaeger-ui/src/components/common/VerticalResizer.tsx Outdated
}
const getDraggingBounds = useCallback((): DraggableBounds => {
if (!rootElmRef.current) {
throw new Error('Invalid state: root element not found');
Copy link
Member

@yurishkuro yurishkuro Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a good idea to be throwing exceptions from a component? Couldn't it just return from the callback?

@Parship999 Parship999 marked this pull request as draft August 10, 2025 08:23
restored comments and update getDraggingBounds
349eb1d 
Signed-off-by: Parship Chowdhury <i.am.parship@gmail.com>
@Parship999 Parship999 marked this pull request as ready for review August 20, 2025 15:44
@Parship999 Parship999 requested a review from yurishkuro August 20, 2025 15:46
@yurishkuro yurishkuro merged commit c44e842 into jaegertracing:main Aug 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@yurishkuro yurishkuro yurishkuro approved these changes

@vishvamsinh28 vishvamsinh28 Awaiting requested review from vishvamsinh28

Assignees

No one assigned

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Parship999 @yurishkuro