Skip to content

Conversation

@Darshit42
Copy link
Contributor

@Darshit42 Darshit42 commented Jul 23, 2025

Which problem is this PR solving?

Description of the changes

How was this change tested?

  • user can now copy the traceid by clicking it
  • before copying
image

after copying

image

Checklist

Signed-off-by: Darshit <shadow6920223@gmail.com>
Signed-off-by: Darshit <shadow6920223@gmail.com>
@Darshit42 Darshit42 requested a review from a team as a code owner July 23, 2025 16:29
@Darshit42 Darshit42 requested review from jkowall and removed request for a team July 23, 2025 16:29
@graphite-app
Copy link
Contributor

graphite-app bot commented Jul 23, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Signed-off-by: Darshit <166272518+Darshit42@users.noreply.github.com>
@Darshit42
Copy link
Contributor Author

Darshit42 commented Jul 23, 2025

@yurishkuro I've opened this new pr, sorry for all the hassle i didn't know pr from main would give error, I've also made changes to fix codecov error

Darshit42 and others added 3 commits July 23, 2025 22:06
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Signed-off-by: Darshit <166272518+Darshit42@users.noreply.github.com>
Signed-off-by: Darshit <shadow6920223@gmail.com>
with:
node-version-file: '.nvmrc'
cache: 'npm'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are all these files changing? please restrict the PR to the actual changes, not formatting (feel free to do a separate PR for formatting fixes)

Copy link
Contributor Author

@Darshit42 Darshit42 Jul 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reverted the formatting fixes for files which are not related to PR

Signed-off-by: Darshit <shadow6920223@gmail.com>
yurishkuro
yurishkuro previously approved these changes Jul 25, 2025
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Jul 25, 2025
@yurishkuro yurishkuro changed the title feat-Click to copy Add Click to copy for trace id Jul 25, 2025
@yurishkuro
Copy link
Member

Please add screenshots

@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.13%. Comparing base (45eb8e8) to head (ec9c299).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2997   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         256      257    +1     
  Lines        7974     8009   +35     
  Branches     2006     2014    +8     
=======================================
+ Hits         7825     7860   +35     
  Misses        149      149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro
Copy link
Member

code coverage and lint are unhappy

Signed-off-by: Darshit <shadow6920223@gmail.com>
@vishvamsinh28
Copy link
Contributor

@Darshit42 Update the branch, and make sure coverage doesn’t drop, increase it.

@Darshit42
Copy link
Contributor Author

@Darshit42 Update the branch, and make sure coverage doesn’t drop, increase it.

i ran npm run coverage the file has 100% coverage

@yurishkuro yurishkuro merged commit cc5c639 into jaegertracing:main Aug 18, 2025
10 checks passed
@yurishkuro
Copy link
Member

Thanks!

@Darshit42
Copy link
Contributor Author

Thanks!

thanks for letting me contribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Add click-to-copy capability to trace ID display

3 participants