-
Notifications
You must be signed in to change notification settings - Fork 665
Add Click to copy for trace id #2997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Darshit <shadow6920223@gmail.com>
Signed-off-by: Darshit <shadow6920223@gmail.com>
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Signed-off-by: Darshit <166272518+Darshit42@users.noreply.github.com>
|
@yurishkuro I've opened this new pr, sorry for all the hassle i didn't know pr from main would give error, I've also made changes to fix codecov error |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Darshit <166272518+Darshit42@users.noreply.github.com>
Signed-off-by: Darshit <shadow6920223@gmail.com>
…into FEAT--Click-To-Copy
| with: | ||
| node-version-file: '.nvmrc' | ||
| cache: 'npm' | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are all these files changing? please restrict the PR to the actual changes, not formatting (feel free to do a separate PR for formatting fixes)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reverted the formatting fixes for files which are not related to PR
Signed-off-by: Darshit <shadow6920223@gmail.com>
|
Please add screenshots |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2997 +/- ##
=======================================
Coverage 98.13% 98.13%
=======================================
Files 256 257 +1
Lines 7974 8009 +35
Branches 2006 2014 +8
=======================================
+ Hits 7825 7860 +35
Misses 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
code coverage and lint are unhappy |
Signed-off-by: Darshit <shadow6920223@gmail.com>
|
@Darshit42 Update the branch, and make sure coverage doesn’t drop, increase it. |
i ran npm run coverage the file has 100% coverage |
|
Thanks! |
thanks for letting me contribute |
Which problem is this PR solving?
Description of the changes
How was this change tested?
after copying
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test