chore: enable several rules from go-critic #7430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
gocritic/enable-all
branch
5 times, most recently
from
8a1aede to
89ff3a1
Compare
yurishkuro
approved these changes
Aug 11, 2025
| - pkg: github.com/jaegertracing/jaeger/internal/proto-gen/api_v2$ | ||
| desc: Use github.com/jaegertracing/jaeger-idl/proto-gen/api_v2 | ||
| gocritic: | ||
| disabled-checks: |
Member
There was a problem hiding this comment.
This is great way to see which linters we are not running. Some of them look useful to enable.
| var queryResponse response | ||
| if err = json.Unmarshal(body, &queryResponse); err != nil { | ||
| err = json.Unmarshal(body, &queryResponse) | ||
| if err != nil { |
Member
There was a problem hiding this comment.
Keeping the original but making err scoped locally with err := would be a better fix
Contributor
Author
There was a problem hiding this comment.
Yes but then you have shadow error from govet
Member
There was a problem hiding this comment.
can rename
if err1 := json.Unmarshal(body, &queryResponse); err1 != nil {
return nil, err1
}
yurishkuro
added
the
changelog:refactoring
Member
|
Unit tests failed |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
gocritic/enable-all
branch
from
89ff3a1 to
a257880
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7430 +/- ##
=======================================
Coverage 96.46% 96.46%
=======================================
Files 377 377
Lines 23071 23084 +13
=======================================
+ Hits 22255 22268 +13
Misses 617 617
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test