Skip to content

Conversation

@yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Dec 17, 2025

Remove label-based filtering which results in the workflow always showing in PR checks as skipped.

Instead run it on file match, and on manual dispatch.

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 17, 2025 03:46
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 17, 2025
@yurishkuro yurishkuro merged commit f83944e into jaegertracing:main Dec 17, 2025
60 checks passed
@yurishkuro yurishkuro deleted the gotip branch December 17, 2025 03:48
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.65%. Comparing base (5171afb) to head (88c5463).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7749      +/-   ##
==========================================
+ Coverage   95.59%   95.65%   +0.05%     
==========================================
  Files         311      311              
  Lines       15519    15617      +98     
==========================================
+ Hits        14836    14938     +102     
+ Misses        535      533       -2     
+ Partials      148      146       -2     
Flag Coverage Δ
badger_v1 9.73% <ø> (-0.16%) ⬇️
badger_v2 2.03% <ø> (-0.04%) ⬇️
cassandra-4.x-v1-manual 14.09% <ø> (+0.05%) ⬆️
cassandra-4.x-v2-auto 2.02% <ø> (-0.04%) ⬇️
cassandra-4.x-v2-manual 2.02% <ø> (-0.04%) ⬇️
cassandra-5.x-v1-manual 14.09% <ø> (+0.05%) ⬆️
cassandra-5.x-v2-auto 2.02% <ø> (-0.04%) ⬇️
cassandra-5.x-v2-manual 2.02% <ø> (-0.04%) ⬇️
clickhouse 1.95% <ø> (-0.03%) ⬇️
elasticsearch-6.x-v1 18.60% <ø> (-0.19%) ⬇️
elasticsearch-7.x-v1 18.63% <ø> (-0.19%) ⬇️
elasticsearch-8.x-v1 18.79% <ø> (-0.19%) ⬇️
elasticsearch-8.x-v2 2.03% <ø> (-0.04%) ⬇️
elasticsearch-9.x-v2 2.03% <ø> (-0.04%) ⬇️
grpc_v1 9.61% <ø> (-0.11%) ⬇️
grpc_v2 2.03% <ø> (-0.04%) ⬇️
kafka-3.x-v2 2.03% <ø> (-0.04%) ⬇️
memory_v2 2.03% <ø> (-0.04%) ⬇️
opensearch-1.x-v1 18.68% <ø> (-0.19%) ⬇️
opensearch-2.x-v1 18.68% <ø> (-0.19%) ⬇️
opensearch-2.x-v2 2.03% <ø> (-0.04%) ⬇️
opensearch-3.x-v2 2.03% <ø> (-0.04%) ⬇️
query 2.03% <ø> (-0.04%) ⬇️
tailsampling-processor 0.59% <ø> (-0.01%) ⬇️
unittests 94.23% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SoumyaRaikwar pushed a commit to SoumyaRaikwar/jaeger that referenced this pull request Dec 18, 2025
Remove label-based filtering which results in the workflow always
showing in PR checks as skipped.

Instead run it on file match, and on manual dispatch.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: SoumyaRaikwar <somuraik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:ci Change related to continuous integration / testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants