Skip to content

Conversation

@mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR updates the FindTraceIDs function in ClickHouse to filter by duration

How was this change tested?

  • Unit tests

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 24, 2025 16:47
@mahadzaryab1 mahadzaryab1 added the changelog:experimental Change to an experimental part of the code label Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.51%. Comparing base (4900d24) to head (c45565b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7767      +/-   ##
==========================================
- Coverage   95.52%   95.51%   -0.02%     
==========================================
  Files         308      308              
  Lines       15469    15475       +6     
==========================================
+ Hits        14777    14781       +4     
- Misses        545      547       +2     
  Partials      147      147              
Flag Coverage Δ
badger_v1 9.64% <0.00%> (-0.01%) ⬇️
badger_v2 2.02% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 14.20% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-auto 2.01% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 2.01% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 14.20% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-auto 2.01% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 2.01% <0.00%> (-0.01%) ⬇️
clickhouse 1.93% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 18.43% <0.00%> (-0.02%) ⬇️
elasticsearch-7.x-v1 18.46% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v1 18.62% <0.00%> (-0.02%) ⬇️
elasticsearch-8.x-v2 2.02% <0.00%> (-0.01%) ⬇️
elasticsearch-9.x-v2 2.02% <0.00%> (-0.01%) ⬇️
grpc_v1 9.52% <0.00%> (-0.01%) ⬇️
grpc_v2 2.02% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 2.02% <0.00%> (-0.01%) ⬇️
memory_v2 2.02% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 18.51% <0.00%> (-0.02%) ⬇️
opensearch-2.x-v1 18.51% <0.00%> (-0.02%) ⬇️
opensearch-2.x-v2 2.02% <0.00%> (-0.01%) ⬇️
opensearch-3.x-v2 2.02% <0.00%> (-0.01%) ⬇️
query 2.02% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.58% <0.00%> (-0.01%) ⬇️
unittests 94.01% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mahadzaryab1 mahadzaryab1 added this pull request to the merge queue Dec 24, 2025
Merged via the queue into jaegertracing:main with commit 6eeab48 Dec 24, 2025
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:experimental Change to an experimental part of the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants