-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[clickhouse] Update FindTraceIDs to filter by complex attributes #7792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7792 +/- ##
==========================================
+ Coverage 95.32% 95.34% +0.01%
==========================================
Files 310 310
Lines 16051 16075 +24
==========================================
+ Hits 15301 15327 +26
+ Misses 581 579 -2
Partials 169 169
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…gertracing#7792) ## Which problem is this PR solving? - Towards jaegertracing#7134 ## Description of the changes - Updated `FindTraceIDs` to filter by complex attributes ## How was this change tested? - Unit tests and manual tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com> Signed-off-by: ThatDeparted2061 <harshraocodesup@gmail.com>
Which problem is this PR solving?
Description of the changes
FindTraceIDsto filter by complex attributesHow was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test