Skip to content

Conversation

@mahadzaryab1
Copy link
Collaborator

@mahadzaryab1 mahadzaryab1 commented Dec 27, 2025

Which problem is this PR solving?

Description of the changes

  • Updated FindTraceIDs to filter by complex attributes

How was this change tested?

  • Unit tests and manual tests

Checklist

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 added the changelog:experimental Change to an experimental part of the code label Dec 27, 2025
@codecov
Copy link

codecov bot commented Dec 27, 2025

Codecov Report

❌ Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.34%. Comparing base (8869af5) to head (2cd49a5).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...nternal/storage/v2/clickhouse/tracestore/reader.go 91.66% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (91.66%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7792      +/-   ##
==========================================
+ Coverage   95.32%   95.34%   +0.01%     
==========================================
  Files         310      310              
  Lines       16051    16075      +24     
==========================================
+ Hits        15301    15327      +26     
+ Misses        581      579       -2     
  Partials      169      169              
Flag Coverage Δ
badger_v1 9.03% <0.00%> (-0.03%) ⬇️
badger_v2 1.90% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v1-manual 13.35% <0.00%> (-0.04%) ⬇️
cassandra-4.x-v2-auto 1.89% <0.00%> (-0.01%) ⬇️
cassandra-4.x-v2-manual 1.89% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v1-manual 13.35% <0.00%> (-0.04%) ⬇️
cassandra-5.x-v2-auto 1.89% <0.00%> (-0.01%) ⬇️
cassandra-5.x-v2-manual 1.89% <0.00%> (-0.01%) ⬇️
clickhouse 1.82% <0.00%> (-0.01%) ⬇️
elasticsearch-6.x-v1 17.24% <0.00%> (-0.05%) ⬇️
elasticsearch-7.x-v1 17.28% <0.00%> (-0.05%) ⬇️
elasticsearch-8.x-v1 17.43% <0.00%> (-0.05%) ⬇️
elasticsearch-8.x-v2 1.90% <0.00%> (-0.01%) ⬇️
elasticsearch-9.x-v2 1.90% <0.00%> (-0.01%) ⬇️
grpc_v1 8.91% <0.00%> (-0.03%) ⬇️
grpc_v2 1.90% <0.00%> (-0.01%) ⬇️
kafka-3.x-v2 1.90% <0.00%> (-0.01%) ⬇️
memory_v2 1.90% <0.00%> (-0.01%) ⬇️
opensearch-1.x-v1 17.32% <0.00%> (-0.05%) ⬇️
opensearch-2.x-v1 17.32% <0.00%> (-0.05%) ⬇️
opensearch-2.x-v2 1.90% <0.00%> (-0.01%) ⬇️
opensearch-3.x-v2 1.90% <0.00%> (-0.01%) ⬇️
query 1.90% <0.00%> (-0.01%) ⬇️
tailsampling-processor 0.55% <0.00%> (-0.01%) ⬇️
unittests 93.90% <91.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review December 27, 2025 17:29
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner December 27, 2025 17:29
@yurishkuro yurishkuro merged commit 47cc078 into jaegertracing:main Dec 27, 2025
61 of 62 checks passed
ThatDeparted2061 pushed a commit to ThatDeparted2061/jaeger that referenced this pull request Dec 31, 2025
…gertracing#7792)

## Which problem is this PR solving?
- Towards jaegertracing#7134

## Description of the changes
- Updated `FindTraceIDs` to filter by complex attributes

## How was this change tested?
- Unit tests and manual tests

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [x] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: ThatDeparted2061 <harshraocodesup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/storage changelog:experimental Change to an experimental part of the code enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants